Add support for custom fields (lookup fields)

[somethingmorerelevant]

Description of change

• Changelog & Version bump
• PR Update CUSTOM_TYPES to include lookup field #124

Manual QA steps

Risks

Rollback steps

• revert this branch

Why interger type for lookup fields and not string
Ans: here

Co-author - @lukas-gust

[cosimon]

Can you add the new field to the all_fields test?

[somethingmorerelevant]

Can you add the new field to the all_fields test?

This is not exactly a new field, but rather a custom field type, and I have setup lookup fields on few streams to validate lookup datatype.

I was thinking to add a new test case for the following reason:

• This type of field is not available on the UI for selection (being a nested field) although the parent object is available for selection
• all_fields_test only covers the fields in the root hierarchy of the object and does not cover nested fields/schema
• the location of lookup fields varies for streams, hence its preferable to validate it separately.

@cosimon what are your thoughts about adding a new test?

[lukas-gust]

Let me know if I can be of any assistance.

[somethingmorerelevant]

Let me know if I can be of any assistance.

I have made some changes as suggested, once the team reviews and approves this change, i will merge this P.R.

[RushiT0122]

Suggested change

	json_type = CUSTOM_TYPES.get(zendesk_type)
	if json_type is None:
	raise Exception("Discovered unsupported type for custom field {} (key: {}): {}"
	.format(field.title,
	field.key,
	zendesk_type))
	json_type = "string"
	LOGGER.critical("Discovered unsupported type for custom field %s (key: %s): %s",
	field.title, field.key, zendesk_type)
	if zendesk_type not in CUSTOM_TYPES:
	LOGGER.critical("Discovered unsupported type for custom field %s (key: %s): %s",
	field.title, field.key, zendesk_type)
	json_type = CUSTOM_TYPES.get(zendesk_type) or "string"

[RushiT0122]

Remove extra line here and other similar locations.

[RushiT0122]

left some some suggestions, also since we are working on these test, this is good opportunity to replace print statements by tap_tester LOGGER.