View install commands #596
Conversation
…quested views Renamed the variables to make it clear what is a view and what is a view name.
|
The latest version makes most of the comments obsolete |
|
okay I started a rough idea - too tired to finish tonight but will try to soon this week! |
This will help to carry around some common data attributes and functions, and reduce redundancy within the ModuleBase class. It also allows for providing fewer variables to the rendered templates since they can come from the module. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
| @@ -52,7 +52,10 @@ def create_from_file( | |||
|
|
|||
| # Extra modules to install | |||
| for install_module in install_modules: | |||
| cli.install(install_module, view=view_name, disable_view=False, force=force) | |||
|
|
|||
| # TODO: can we cut out early if already installed? | |||
There was a problem hiding this comment.
OK, I'll keep that in mind when implementing reinstall and upgrade. I could split force into specific flags (like ignore-missing and uninstall-missing in upgrade)
|
Here it is, I've split |
There was a problem hiding this comment.
This is a heck of a lot neater - I really like it! Some small tweaks, and then given you've taken the basic changes for a spin and are happy, I'm good to merge this into main and keep working. I think your other PR #590 is going to add some really good functionality, and we can finish up there and ping Marco to see what he thinks before doing a release.
And I'm also down to keep iterating on improving the new Module class to better handle some of the logic - let me know if you see / think of something that can be improved and I'll be on it!
Co-authored-by: Vanessasaurus <[email protected]>
config.name was not wrong Co-authored-by: Vanessasaurus <[email protected]>
|
Looks good to me ! I'll rebase #590 once this is merged. |
Hi.
Here is a pull-request to address #590 (comment) and #590 (comment)
shpc installdoesn't accept a--viewargument anymore.shpc view installnow honours the default view, as set in the settings.viewanddisable_viewarguments of theinstallmethod to resp.extra_viewanddisable_default_viewto clarify what they refer to.Footnotes
tcsh still doesn't run
shpc test. I've tried to add it, but couldn't manage to make it work: it complains thatmoduleis not found even though the module commands work. I found something weird:shpc testalways runs the test script with bash even if the user requested a different test shell. I tried using the test shell throughout but it didn't help. And anyway, tcsh is not allowed as a shell. ↩