Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional unit flexibility for download/upload speeds. #779

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Windows81
Copy link

When it comes to measuring internet speeds, I like to have all my units in mebibytes/second, as this is how both OS-level file managers and web browsers would display object sizes and download speeds. Although speedtest-cli allow speeds to be displayed in megabytes/second, having a multiplication factor of 1.048576 makes it inconvenient for when you happen to be comparing similar test results that may have happened to come from outside sources. As with Okla, I've also added other units too!

I should also disclose that this is my first time contributing to open-source software.

@maulanaaghnii
Copy link

.

@Windows81
Copy link
Author

Hello @sivel. I wanted to follow up with this pull request. Please review the changes at your earliest convenience. Thanks in advance for the merge!

@Windows81
Copy link
Author

Hey. Just wanted to follow up once again. The utility already works on Python 3.12, but I replaced datetime.datetime.utcnow() with datetime.datetime.now(datetime.UTC), as per the deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants