want to get check TypeScript versions too

sjml · Dec 13, 2024 · 14c4ed5 · 14c4ed5
1 parent 530af6f
commit 14c4ed5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,6 +44,7 @@ jobs:
     strategy:
       matrix:
         node-version: ['18', '20', '22']
+        typescript-version: ['4', '5']
     steps:
     - uses: actions/checkout@v4
     - name: Setup Python
@@ -58,13 +59,18 @@ jobs:
       uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
-    - name: Run Tests (Node v${{ matrix.node-version }})
+    - name: Configure TypeScript Version
+      run: |
+        jq ".devDependencies.typescript = \"${{ matrix.typescript-version }}\"" test/_harnesses/typescript/package.json > tmp.json
+        mv tmp.json test/_harnesses/typescript/package.json
+        cat test/_harnesses/typescript/package.json
+    - name: Run Tests (Node v${{ matrix.node-version }} / TypeScript v${{ matrix.typescript-version }})
       run: |
         pytest --only typescript
     - name: Upload Generated Messages
       uses: actions/upload-artifact@v4
       with:
-        name: typescript-node${{ matrix.node-version }}-generated-messages
+        name: typescript-node${{ matrix.node-version }}-typescript${{ matrix.typescript-version }}-generated-messages
         path: out/data
 
   go-builds:

diff --git a/test/_harnesses/typescript/package.json b/test/_harnesses/typescript/package.json
@@ -2,10 +2,10 @@
   "name": "typescript-harness",
   "private": true,
   "devDependencies": {
-    "@types/minimist": "^1.2.5",
-    "@types/node": "^22.8.2",
-    "minimist": "^1.2.8",
-    "tsx": "^4.19.2",
-    "typescript": "^5.6.3"
+    "@types/minimist": "*",
+    "@types/node": "*",
+    "minimist": "*",
+    "tsx": "*",
+    "typescript": "*"
   }
 }