Skip to content

Commit

Permalink
need to look at GCC warnings another time
Browse files Browse the repository at this point in the history
  • Loading branch information
sjml committed Nov 15, 2024
1 parent e285707 commit 6e98413
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion beschi/writers/c.py
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ def gen_implementation(self, sname: str, sdata: Struct):
if sdata.is_message:
self.write_line("if (tag) {")
self.indent_level += 1
self.write_line(f"err = {self.prefix}_WriteUInt8(w, (const uint8_t)(src->_mt));")
self.write_line(f"err = {self.prefix}_WriteUInt8(w, (uint8_t)(src->_mt));")
self.err_check_return()
self.indent_level -= 1
self.write_line("}")
Expand Down
1 change: 1 addition & 0 deletions docs/dev/todo.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ This file is a rough todo list for the tool itself.

## dustoff notes
- add endian handling to C writer for the sake of completion
- GCC has found some more warnings if -Wextra is turned on; look at those
- test suite for destroying and cleaning up messages
- add notes about trustworthiness
- all reading code assumes it's reading stuff that was written by a corresponding writer
Expand Down
3 changes: 2 additions & 1 deletion test/_harnesses/c/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
# FLAGS += ["-Wall", "-Wextra"] # the recommended setting from clang
else:
# assuming that non-clang is GCC
FLAGS += ["-Wall", "-Wextra"]
# FLAGS += ["-Wall", "-Wextra"] #
FLAGS += ["-Wall"]
FLAGS += [
"-Werror", # complain loudly
"-O0", "-g", # have as much debug info as we can
Expand Down

0 comments on commit 6e98413

Please sign in to comment.