Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 2 #2

Merged
merged 2 commits into from
Feb 16, 2013
Merged

Upgrade to Bootstrap 2 #2

merged 2 commits into from
Feb 16, 2013

Conversation

j4mie
Copy link
Contributor

@j4mie j4mie commented Feb 9, 2012

Also reworked the profile list to use Bootstrap thumbnails (with some custom tweaks to remove the border/shadows) so they line up a bit better.

I've moved the Bootstrap CSS into the media directory as the Bootstrap docs site no longer seems to encourage hotlinking it. I tried adding the responsive stylesheet, but it screwed things up due to the custom width set on .container. Probably not too trick to fix.

@almost
Copy link
Member

almost commented Feb 12, 2012

Thanks Jamie! Upgrading to Bootstrap 2.0 was definitely needed.

A few small problems I'm seeing at the moment:

  • Extra space is showing up above the and below the top bar
  • Presence indicators are no longer showing over the images
  • Divider line is gone between the main contents and the tweets (does this matter? not sure)

Are you planning on coming to the mini-SkiffHack on Friday afternoon? Maybe we can sort out these issues then?

Thanks again for contributing!

@j4mie
Copy link
Contributor Author

j4mie commented Feb 12, 2012

Hmm. What browser? I thought I'd fixed all that stuff..

@almost
Copy link
Member

almost commented Feb 12, 2012

Haha, yes, important details :p

It's Chrome on Snow Leopard. If you still can't see it I can send screenshots or show you on my laptop tomorrow at BrightonPy...

@j4mie
Copy link
Contributor Author

j4mie commented Feb 12, 2012

I'll have a look when I get a chance!

almost added a commit that referenced this pull request Feb 16, 2013
@almost almost merged commit 913fce2 into skiffhack:master Feb 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants