Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widget: add support for taddrs on penumbra #759

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

erwanor
Copy link

@erwanor erwanor commented Feb 6, 2025

This PR:

  • restores USDC flows from noble using transparent addresses
  • otherwise defaults to ephemeral addresses

I wasn't able to test the PR end-to-end, because trying to generate a route leads me to this error:

Screenshot 2025-02-05 at 11 42 13 PM

Which I couldn't trace the source of. I think this might coming from the solver backend directly? unsure. If you tell me where to look I should be able to test this.

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 9405beb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 6, 2025

@erwanor is attempting to deploy a commit to the Skip Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@ericHgorski
Copy link
Collaborator

@NotJeremyLiu to test end-to-end with local API

@erwanor
Copy link
Author

erwanor commented Feb 8, 2025

@NotJeremyLiu opened #770, if you test this PR you will learn that the current address validation in the client packages does not handle Penumbra. Hopefully this saves some time, happy to test things here with you if that's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants