fix: prevent from encoding already encoded url links (#8)

skoropadas · Apr 14, 2024 · 5b75aeb · 5b75aeb
1 parent f0ac6cb
commit 5b75aeb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/telegramify.js b/lib/telegramify.js
@@ -70,7 +70,8 @@ const createHandlers = (definitions, unsupportedTagsStrategy) => ({
 	link: (node, _parent, context) => {
 		const exit = context.enter('link');
 		const text = phrasing(node, context, {before: '|', after: '>'}) || escapeSymbols(node.title);
-		const url = encodeURI(node.url);
+		const isUrlEncoded = decodeURI(node.url) !== node.url;
+		const url = isUrlEncoded ? node.url : encodeURI(node.url);
 		exit();
 
 		if (!isURL(url)) return escapeSymbols(text) || escapeSymbols(url);

diff --git a/tests/convert.spec.js b/tests/convert.spec.js
@@ -89,6 +89,12 @@ describe('Test convert method', () => {
 		expect(convert(markdown)).toBe(tgMarkdown);
 	});
 
+	it('Link with invalid URL', () => {
+		const markdown = '[test](/atlassian)';
+		const tgMarkdown = 'test\n';
+		expect(convert(markdown)).toBe(tgMarkdown);
+	});
+
 	it('Link with parentheses', () => {
 		const markdown = '[Atlassian](http://atlas()sian.com)';
 		const tgMarkdown = '[Atlassian](http://atlas\\(\\)sian.com)\n';