Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using your module as a
ES
module like thisthe following compile error occurs:
The issue is explained here
and it basically says you can't use
export =
andexport
together in one modulebecause it mixes up
commonjs
module andES
module syntax.I found the simple fix is removing the export on
UnsupportedTagsStrategy
,because the module will simply continue to work as is.
The autocompletion on the second parameter of
convert
also continues to work.While at it you can add to your README somewhere that
is the
ES
module compatible import.