[ENH] retain config after clone, add config to configure whether to clone config
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 83.94% 84.16% +0.21%
==========================================
Files 43 43
Lines 2922 2924 +2
==========================================
+ Hits 2453 2461 +8
+ Misses 469 463 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that set config fields are cloned, when using
clone.This behaviour can be reverted to current via a new config
clone_config.Related: sktime/sktime#5676
An important question: is the current behaviour close enough to being a bug, or very unexpected, as to not require deprecation, because we treat this as a bugfix?
Or is it an unexpected change, which would require deprecation?
An example would be, (a) first configuring an estimator via
set_config, e.g., parallelization, (b) then wrapping it in a composite. This procedure would turn off an configs in the internally cloned estimator.To me, this seems like a "bug" rather than "can be expected".