-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for updating contributors #395
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Track updates on both branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I updated from main
- including the reverted changes from the README.
It would be nice to have an updating section in the readme with profile pictures, but this is not blocking.
I would also suggest to show emoji keys primarily, since they also acknowledge non-code contributions. (Count of commits is also misleading a bit, since part of the code base was copied over from sktime
, so the initial contributions to these base classes are not tracked in the commit history. Early contributions are also inflated, as PR commit practice was not well-established then.)
So instead of quoating the number of commits , I need to display then contribution type in the form of emojis? Am I going right on this?? |
The pictures are nice, is this automtaed? I think there is a script somewhere that generates the table of contributors, as in sktime - like this https://www.sktime.net/en/latest/about/contributors.html |
@fkiraly |
yes - is there not an automated script doing that, somewhere? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 85.07% 85.77% +0.70%
==========================================
Files 45 48 +3
Lines 3015 3311 +296
==========================================
+ Hits 2565 2840 +275
- Misses 450 471 +21 ☔ View full report in Codecov by Sentry. |
I think this is the script that automates the file
|
@fkiraly |
is this ready for review, or still a work in progress? If ready, could you summarize how the automation functions? |
Yes! It is ready for merge
|
Could not find the user |
@fkiraly like this , it automatically responds to the instruction |
Nice! One question: why does it respond to your instruction, given that you do not have write access to this repo? |
I simply guess when we tag the bot, it responds. |
Alright, let me try: @all-contributors please add @Spinachboul for code |
I've put up a pull request to add @Spinachboul! 🎉 |
Reference to discussion in PR #394
Adds the
update_contributors.yml
CI which is same as insktime