Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for updating contributors #395

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Spinachboul
Copy link
Contributor

Reference to discussion in PR #394

Adds the update_contributors.yml CI which is same as in sktime

Copy link
Contributor

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I updated from main - including the reverted changes from the README.

It would be nice to have an updating section in the readme with profile pictures, but this is not blocking.

I would also suggest to show emoji keys primarily, since they also acknowledge non-code contributions. (Count of commits is also misleading a bit, since part of the code base was copied over from sktime, so the initial contributions to these base classes are not tracked in the commit history. Early contributions are also inflated, as PR commit practice was not well-established then.)

@Spinachboul
Copy link
Contributor Author

Thanks!

I updated from main - including the reverted changes from the README.

It would be nice to have an updating section in the readme with profile pictures, but this is not blocking.

I would also suggest to show emoji keys primarily, since they also acknowledge non-code contributions. (Count of commits is also misleading a bit, since part of the code base was copied over from sktime, so the initial contributions to these base classes are not tracked in the commit history. Early contributions are also inflated, as PR commit practice was not well-established then.)

So instead of quoating the number of commits , I need to display then contribution type in the form of emojis? Am I going right on this??
Though I did add the pictures of the contributors in the readme section

@Spinachboul
Copy link
Contributor Author

Contributors

Can I add the pictures like this? After the emoji-key

@fkiraly
Copy link
Contributor

fkiraly commented Jan 23, 2025

The pictures are nice, is this automtaed?

I think there is a script somewhere that generates the table of contributors, as in sktime - like this https://www.sktime.net/en/latest/about/contributors.html

@Spinachboul
Copy link
Contributor Author

@fkiraly
You mean maybe in here, we can add the contributors pictures like in this link?
https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md

@fkiraly
Copy link
Contributor

fkiraly commented Jan 26, 2025

@fkiraly You mean maybe in here, we can add the contributors pictures like in this link? https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md

yes - is there not an automated script doing that, somewhere?

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (306958d) to head (51e1bb9).
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   85.07%   85.77%   +0.70%     
==========================================
  Files          45       48       +3     
  Lines        3015     3311     +296     
==========================================
+ Hits         2565     2840     +275     
- Misses        450      471      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spinachboul Spinachboul requested a review from fkiraly February 5, 2025 06:14
@Spinachboul
Copy link
Contributor Author

Spinachboul commented Feb 5, 2025

@fkiraly You mean maybe in here, we can add the contributors pictures like in this link? https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md

yes - is there not an automated script doing that, somewhere?

I think this is the script that automates the file contributors.md

npm install -g all-contributors-cli
all-contributors add <github-username> <contribution-types>

@Spinachboul
Copy link
Contributor Author

@fkiraly
Also sktime has this workflow called update_contributors.yml which is missing in skbase
We need to include that also to automate the whole thing
I have included that in this PR

@fkiraly
Copy link
Contributor

fkiraly commented Feb 5, 2025

is this ready for review, or still a work in progress?

If ready, could you summarize how the automation functions?

@Spinachboul
Copy link
Contributor Author

is this ready for review, or still a work in progress?

If ready, could you summarize how the automation functions?

Yes! It is ready for merge
So there are primarily 2 approaches for automation

  • Github Actions
    The workflow update_contributors.yml (also included in this PR) runs automatically commands like npx all-contributors generate whenever a trigger event occurs

  • A manual task using the command @all-contributors please add @username for code
    which is to instruct the All Contributors Bot

Copy link

@Spinachboul

Could not find the user username on github.

@Spinachboul
Copy link
Contributor Author

@Spinachboul

Could not find the user username on github.

@fkiraly like this , it automatically responds to the instruction

@fkiraly
Copy link
Contributor

fkiraly commented Feb 5, 2025

Nice! One question: why does it respond to your instruction, given that you do not have write access to this repo?

@Spinachboul
Copy link
Contributor Author

Nice! One question: why does it respond to your instruction, given that you do not have write access to this repo?

I simply guess when we tag the bot, it responds.
I am not sure why that is happening

@fkiraly
Copy link
Contributor

fkiraly commented Feb 5, 2025

Alright, let me try:

@all-contributors please add @Spinachboul for code

Copy link

@fkiraly

I've put up a pull request to add @Spinachboul! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants