Merge pull request #9 from skuid/PLIN-3031-Condition_logic_fix

PLIN-3031: allow negative index for 0-indexed array alignment
skuid · May 17, 2021 · 1ad29e0 · 1ad29e0
2 parents 3823eb1 + 3b215fd
commit 1ad29e0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/parse/index.go b/parse/index.go
@@ -5,7 +5,7 @@ import (
 )
 
 // Index Op will index the left and right nodes
-func (o *Op) Index(start uint) Node {
+func (o *Op) Index(start int) Node {
 
 	var left Node
 	var right Node
@@ -26,9 +26,9 @@ func (o *Op) Index(start uint) Node {
 }
 
 // Index Leaf will add start to the current value
-func (l *Leaf) Index(start uint) Node {
+func (l *Leaf) Index(start int) Node {
 	return &Leaf{
-		Val: l.Val + start,
+		Val: uint(int(l.Val) + start),
 	}
 }
 

diff --git a/parse/index_test.go b/parse/index_test.go
@@ -10,7 +10,7 @@ func TestIndex(t *testing.T) {
 	cases := []struct {
 		desc     string
 		fixture  Node
-		start    uint
+		start    int
 		expected Node
 	}{
 		{

diff --git a/parse/tree.go b/parse/tree.go
@@ -9,7 +9,7 @@ import (
 type Node interface {
 	Remove(uint) Node
 	Eval(io.Writer) error
-	Index(uint) Node
+	Index(int) Node
 }
 
 // Leaf is a concrete Node that will hold a single value