Fixes PLIN-2287 Improve Picard Filtering #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acofer
reviewed
Aug 6, 2019
| if filters != nil && len(filters) > 0 && modelVal != nil { | ||
| for _, filter := range filters { | ||
| fieldMetadata := filterMetadata.GetField(filter.FieldName) | ||
| tbl.AddWhere(fieldMetadata.GetColumnName(), filter.FilterValue) |
There was a problem hiding this comment.
Does this still work if we have multiple filter values on the same field? The way I read the squirrel docs, it defaults to AND, so (assuming column name is id and filter.FilterValue is foo etc.) this will add WHERE id=foo AND id=bar AND id=baz, so we end up getting nothing back. That's why I added WHERE id IN (foo, bar, baz) instead.
There was a problem hiding this comment.
Line 83 in 5ff5724
There was a problem hiding this comment.
Yeah, squirrel turns slices into Where Ins. The tests show it in action. This is from squirrel docs.
There was a problem hiding this comment.
Ah, cool. Thanks for figuring this out.
acofer
requested changes
Aug 6, 2019
| @@ -63,6 +63,7 @@ func buildQuery( | |||
| modelVal *reflect.Value, | |||
| filters []qp.FieldFilter, | |||
| associations []tags.Association, | |||
| selectFields []string, | |||
There was a problem hiding this comment.
good catch, I'll fix it.
acofer
approved these changes
Aug 6, 2019
ghost
unassigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FieldFilters to FilterRequests. Since FilterModels must be an actual instance of the struct being queried, we cannot add special filters like whereIn with a FilterModel. This PR adds FieldFilters to allow for more complex filters.
Improve performance by using cached struct metadata instead of getting it on each iteration of a loop. This completely removes struct metadata gathering from the hydrate function, which was getting called for each record returned. If we can rely on the trace PDF that I saw in another ticket, I believe this should be helpful.
Removes the ReflectTableInfo and GetPK functions in favor of previously existing functions.