Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1650: Added the version field to the site entity #1717

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

ganeshmurthy
Copy link
Contributor

No description provided.

@ganeshmurthy ganeshmurthy requested a review from ted-ross January 17, 2025 14:46
Copy link
Member

@ted-ross ted-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggested improvement.

@@ -650,6 +650,12 @@
"required": false,
"create": true
},
"version": {
"description":"Build version of skupper",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this a little more descriptive: "Build version of the running control-plane software"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this a little more descriptive: "Build version of the running control-plane software"

Done !

@ganeshmurthy ganeshmurthy merged commit 1fb1a72 into skupperproject:main Jan 17, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants