Fixes #1723: For inter-router connectors, force set the dataConnectio…

[ganeshmurthy]

…nCount to 1 if it is set to 0

[kgiusti]

Not something you changed but maybe this description should be more specific WRT the connection role. Like "Applies only to connectors with a role of "inter-router"??? Or something like that...

[kgiusti]

Stepping back a bit - I don't like how the data connection count is stored as a string then constantly re-computed every time a new connector is created. I'm not being critical about your patch - reviewing your patch leads me to believe the original implementation of the data connection count leaves room for improvement.

For example, the data connection count is stored in the router configuration record. It's value is initially read in dispatch.c::qd_dispatch_configure_router. That code simply stores it in a string. But then the actual computation of the data connection count integer is buried in the connection manager. That computation must be repeated every time a new connector is created.

This seems complicated and the logic is needlessly spread across files.

Wouldn't it be simpler to:

1. Compute the actual value of data connection count in the qd_dispatch_configure_router routine where the configuration is read?
   1a) By "compute" I mean translate the string "auto" to the actual integer value based on the number of worker threads. The number of worker threads is also read from the same configuration record as the data connection count so it's immediately accessible.
2. store the data connection count as an integer, not a string. We need an integer, not a string.

Then you can remove all the extra logic in connection_manager.c::qd_dispatch_configure_connector() for computing the integer value of data connection count and simply copy it from the qd parameter.

Then those access functions that go through the core (via the management thread - shudder) can be removed. Specifically connection_manager.c::auto_calc_connection_count and also qdr_core_get_worker_thread_count which is totally unnecessary since the thread count is available in the qd parameter.

I think that would greatly simplify the implementation of the data_connection_count configuration - what do you think?

[ganeshmurthy]

what do you think?

I will embark on this mission and will keep you posted.