Skip to content

Commit

Permalink
replace v2 latest references (#1888)
Browse files Browse the repository at this point in the history
  • Loading branch information
nluaces authored Jan 15, 2025
1 parent 5c2da4a commit 2126e1a
Show file tree
Hide file tree
Showing 15 changed files with 27 additions and 27 deletions.
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ yaml-templates:
filters:
branches:
ignore: /.*/
only: /v2/
only: /main/

release_filters: &run_for_numeric_tags
filters:
Expand Down Expand Up @@ -144,20 +144,20 @@ workflows:
- test:
<<: *run_for_all_branches
- build-oci-images:
image_tag: v2-latest
image_tag: v2-dev
<<: *run_for_all_branches
- publish-oci-images:
<<: *run_for_v2_branch
<<: *v2_release_requires
image_tag: v2-latest
image_tag: v2-dev
context:
- skupper-org
- generate-manifest:
requires:
- publish-oci-images
- publish-github-prerelease-artifacts:
<<: *run_for_v2_branch
version: v2-release
version: v2-dev-release
requires:
- publish-oci-images
- generate-manifest
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile.network-observer
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ RUN make GOARCH=$TARGETARCH build-network-observer
FROM --platform=$BUILDPLATFORM node:20.9.0 AS console-builder

WORKDIR /skupper-console/
ADD https://github.com/skupperproject/skupper-console/archive/v2.tar.gz .
RUN tar -zxf v2.tar.gz
WORKDIR ./skupper-console-2
ADD https://github.com/skupperproject/skupper-console/archive/main.tar.gz .
RUN tar -zxf main.tar.gz
WORKDIR ./skupper-console-main
RUN yarn install && yarn build

FROM --platform=$TARGETPLATFORM registry.access.redhat.com/ubi9-minimal
Expand All @@ -34,5 +34,5 @@ USER 10000

WORKDIR /app
COPY --from=builder /go/src/app/network-observer .
COPY --from=console-builder /skupper-console/skupper-console-2/build/ console
COPY --from=console-builder /skupper-console/skupper-console-main/build/ console
ENTRYPOINT ["/app/network-observer"]
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ GOOS ?= linux
GOARCH ?= amd64

REGISTRY := quay.io/skupper
IMAGE_TAG := v2-latest
IMAGE_TAG := v2-dev
PLATFORMS ?= linux/amd64,linux/arm64
CONTAINERFILES := Dockerfile.cli Dockerfile.kube-adaptor Dockerfile.controller Dockerfile.network-observer
SHARED_IMAGE_LABELS = \
Expand Down
2 changes: 1 addition & 1 deletion charts/skupper-setup/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v2
name: skupper-setup
description: Helm chart for setting up Skupper.
version: 0.1.0-devel
appVersion: v2-latest
appVersion: v2-dev
4 changes: 2 additions & 2 deletions charts/skupper-setup/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
images:
controller: "quay.io/skupper/controller:v2-latest"
adaptor: "quay.io/skupper/kube-adaptor:v2-latest"
controller: "quay.io/skupper/controller:v2-dev"
adaptor: "quay.io/skupper/kube-adaptor:v2-dev"

# available options: cluster, namespace
scope: cluster
2 changes: 1 addition & 1 deletion cmd/bootstrap/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Bootstrapping non-kubernetes sites

In this current phase of the Skupper V2 implementation, non-kubernetes sites
can be bootstrapped using the Skupper CLI, using the quay.io/skupper/skupper-cli:v2-latest
can be bootstrapped using the Skupper CLI, using the quay.io/skupper/skupper-cli:v2-dev
container image by calling `./cmd/bootstrap/bootstrap.sh` with the appropriate
flags.

Expand Down
2 changes: 1 addition & 1 deletion cmd/bootstrap/bootstrap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -Ceu

IMAGE="quay.io/skupper/cli:v2-latest"
IMAGE="quay.io/skupper/cli:v2-dev"
export INPUT_PATH=""
export NAMESPACE=""
export FORCE_FLAG=""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ spec:
app.kubernetes.io/component: server
spec:
containers:
- image: quay.io/skupper/network-observer:v2-latest
- image: quay.io/skupper/network-observer:v2-dev
imagePullPolicy: Always
name: network-observer
args:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ spec:
app.kubernetes.io/component: server
spec:
containers:
- image: quay.io/skupper/network-observer:v2-latest
- image: quay.io/skupper/network-observer:v2-dev
imagePullPolicy: Always
name: network-observer
args:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ spec:
app.kubernetes.io/component: server
spec:
containers:
- image: quay.io/skupper/network-observer:v2-latest
- image: quay.io/skupper/network-observer:v2-dev
imagePullPolicy: Always
name: network-observer
args:
Expand Down
2 changes: 1 addition & 1 deletion cmd/network-observer/resources/native/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ spec:
app.kubernetes.io/component: server
spec:
containers:
- image: quay.io/skupper/network-observer:v2-latest
- image: quay.io/skupper/network-observer:v2-dev
imagePullPolicy: Always
name: network-observer
args:
Expand Down
2 changes: 1 addition & 1 deletion cmd/network-observer/resources/openshift/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
serviceAccountName: network-observer
containers:
- name: network-observer
image: quay.io/skupper/network-observer:v2-latest
image: quay.io/skupper/network-observer:v2-dev
imagePullPolicy: Always
args:
- -listen=127.0.0.1:8080
Expand Down
6 changes: 3 additions & 3 deletions internal/nonkube/client/compat/container_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func TestContainer(t *testing.T) {
})

// Updating container image
image = strings.ReplaceAll(image, ":main", ":latest")
image = strings.ReplaceAll(image, ":v2-latest", ":latest")
t.Run("container-update-image", func(t *testing.T) {
c, err := cli.ContainerUpdateImage(ctx, name, image)
assert.Assert(t, err)
Expand Down Expand Up @@ -328,7 +328,7 @@ func TestContainerUpdateMock(t *testing.T) {
assert.Assert(t, err)
assert.Equal(t, len(cl), 1)

newImage := strings.Replace(image, ":main", ":updated", -1)
newImage := strings.Replace(image, ":v2-latest", ":updated", -1)
_, err = cli.ContainerUpdateImage(context.Background(), "my-container", newImage)
assert.Assert(t, err)

Expand All @@ -346,7 +346,7 @@ func TestContainerUpdateMock(t *testing.T) {

func TestContainerUpdateErrorMock(t *testing.T) {
image := images.GetRouterImageName()
newImage := strings.Replace(image, ":main", ":updated", -1)
newImage := strings.Replace(image, ":v2-latest", ":updated", -1)
cli := NewCompatClientMock(mockContainers(image))
mock := cli.RestClient.(*RestClientMock)

Expand Down
8 changes: 4 additions & 4 deletions pkg/images/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ package images
const (
DefaultImageRegistry string = "quay.io/skupper"
RouterImageName string = "skupper-router:main"
ControllerImageName string = "controller:v2-latest"
KubeAdaptorImageName string = "kube-adaptor:v2-latest"
NetworkObserverImageName string = "network-observer:v2-latest"
CliImageName string = "cli:v2-latest"
ControllerImageName string = "controller:v2-dev"
KubeAdaptorImageName string = "kube-adaptor:v2-dev"
NetworkObserverImageName string = "network-observer:v2-dev"
CliImageName string = "cli:v2-dev"

PrometheusImageRegistry string = "quay.io/prometheus"
PrometheusServerImageName string = "prometheus:v2.42.0"
Expand Down
2 changes: 1 addition & 1 deletion scripts/oci-index-archive-info.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

REGISTRY=${REGISTRY:-quay.io/skupper}
IMAGE_TAG=${IMAGE_TAG:-"v2-latest"}
IMAGE_TAG=${IMAGE_TAG:-"v2-dev"}
ARCHIVES_PATH=${ARCHIVES_PATH:-./oci-archives}

skopeo::digest (){
Expand Down

0 comments on commit 2126e1a

Please sign in to comment.