Skip to content

Commit

Permalink
Move lint step after build, for protoc.
Browse files Browse the repository at this point in the history
  • Loading branch information
johnspurlock-skymethod committed Dec 4, 2023
1 parent 889858b commit 32c7903
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,6 @@ jobs:
- name: Check formatting
run: cargo fmt -- --check
working-directory: ./napi
- name: Check linting
run: cargo clippy --release --all-targets --all-features -- -D clippy::all
working-directory: ./napi
- name: Setup node x86
if: matrix.settings.target == 'i686-pc-windows-msvc'
run: yarn config set supportedArchitectures.cpu "ia32"
Expand Down Expand Up @@ -120,6 +117,9 @@ jobs:
if: ${{ !matrix.settings.docker }}
shell: bash
working-directory: ./napi
- name: Check linting # needs to run after build so protoc is available
run: cargo clippy --release --all-targets --all-features -- -D clippy::all
working-directory: ./napi
- name: Upload artifact
uses: actions/upload-artifact@v3
with:
Expand Down

0 comments on commit 32c7903

Please sign in to comment.