Fix optional napi interface opt check.

skymethod · Dec 2, 2023 · 5f49b7c · 5f49b7c
1 parent 64f13c7
commit 5f49b7c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/check.ts b/src/check.ts
@@ -48,8 +48,8 @@ export function checkOptionalFunction(name: string, value: unknown): asserts val
     if (!(value === undefined || typeof value === 'function')) throw new TypeError(`Bad '${name}': expected optional function, found ${value}`);
 }
 
-export function checkObject(name: string, value: unknown): asserts value is object {
-    if (typeof value !== 'object') throw new TypeError(`Bad '${name}': expected object, found ${value}`);
+export function checkOptionalObject(name: string, value: unknown): asserts value is object {
+    if (!(value === undefined || typeof value === 'object')) throw new TypeError(`Bad '${name}': expected optional object, found ${value}`);
 }
 
 export function check(name: string, value: unknown, valid: boolean) {

diff --git a/src/napi_based.ts b/src/napi_based.ts
@@ -1,4 +1,4 @@
-import { checkObject, checkOptionalBoolean, checkOptionalFunction, checkOptionalString, checkRecord, isRecord } from './check.ts';
+import { checkOptionalBoolean, checkOptionalFunction, checkOptionalObject, checkOptionalString, checkRecord, isRecord } from './check.ts';
 import { decodeAtomicWriteOutput, decodeSnapshotReadOutput, encodeAtomicWrite, encodeSnapshotRead } from './kv_connect_api.ts';
 import { packKey } from './kv_key.ts';
 import { KvConsistencyLevel, KvEntryMaybe, KvKey, KvService } from './kv_types.ts';
@@ -79,7 +79,7 @@ class NapiBasedKv extends ProtoBasedKv {
         checkOptionalString('url', url);
         checkRecord('opts', opts);
         checkOptionalBoolean('opts.debug', opts.debug);
-        checkObject('opts.napi', opts.napi);
+        checkOptionalObject('opts.napi', opts.napi);
         checkOptionalFunction('opts.decodeV8', opts.decodeV8);
         checkOptionalFunction('opts.encodeV8', opts.encodeV8);
         checkOptionalBoolean('opts.inMemory', opts.inMemory);