Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: angular 10 updates #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NathanWalker
Copy link

No description provided.

@ccondrup
Copy link

Should this branch work as is on Angular 10? The currently released version yields console warnings that it's a CommonJS dependency, so I was hoping this branch would remedy that, but this is all new to me. I tried:
npm install --save NathanWalker/ngx-google-places-autocomplete#feat/angular-10

What should my imports be updated to? I currently have
import { GooglePlaceModule } from 'ngx-google-places-autocomplete'; which yields:

TS2307: Cannot find module 'ngx-google-places-autocomplete' or its corresponding type declarations.

Is it just that types are missing? I see index.d.ts referenced but I don't see any declaration files.
Any help appreciated.

@IslombekHasan
Copy link

@ccondrup i'm having this warning too, it'd be great to convert all CommonJS modules to ECMAScript modules, since CommonJS obstructs tree-shaking of modules.
@skynet2, is there any chance to fix this, sir?

@rjfahl
Copy link

rjfahl commented Jan 26, 2021

@skynet2 Any update on this? I would like to get the optimizations from removing the CommonJS modules and remove the warning from my build process.

@jaradehr1
Copy link

@skynet2 Any update on this? I would like to get the optimizations from removing the CommonJS modules and remove the warning from my build process.

I think the devs have changed the tsconfig.json and replaced the CommonJS module with es2017 module..

Check the last commit here
f7cd3f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants