Keep updating v5 #106
Open
Keep updating v5 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
force-pushed
the
keep-updating-v5
branch
from
6e8c993 to
5d21c9d
Compare
romilbhardwaj
approved these changes
Dec 13, 2024
| # compatibility. | ||
| # TODO(zhwu): Remove v5 support after 0.10.0 release. | ||
| version_commit: | ||
| v5: 1ed40e3174646ba835423b9308d8d6489f83b6bc |
There was a problem hiding this comment.
Just so I understand: when we update catalog fetchers in our main skypilot repo, this hash would also need to be updated?
If so, we should probably make a note of this in README.md
| # TODO(zhwu): Remove v5 support after 0.10.0 release. | ||
| version_commit: | ||
| v5: 1ed40e3174646ba835423b9308d8d6489f83b6bc | ||
| v6: latest |
There was a problem hiding this comment.
Should we also add a quick update to README.md for this repo that v6 is now a supported catalog version? Can be another PR too.
There was a problem hiding this comment.
Good catch! Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we bump the version to v6. We should keep updating the v5 so that the older version skypilot user can get the latest catalogs.