Enable RememberObserver to work with rememberRetained #1210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually calls
RememberObserver
calls as appropriate when used inrememberRetained
. The semantics ofrememberRetained
are obviously different toremember
, so we call them at different times:onRemembered
will be called the first time that the retained item is firstremember
ed. The difference here is that we will not callonRemembered
again once a the object is restored and remembered back into composition.onForgotten
will be called only once the retained state is cleared from both composition and any retained registries.onRemembered
called), through to being no longer retained/remembered (onForgotten
called).onAbandoned
as retained state doesn't meet the contract of the function.I did think about creating a
RetainedObserver
interface, but figured that using the existingRememberObserver
, even with slightly different semantics, is a better solution.This has a variety of use-cases, but I have been playing around with a
rememberRetainedCorotineScope
in Tivi: chrisbanes/tivi#1763