Skip to content

Commit

Permalink
using pr_err instead of pr_info for error printing
Browse files Browse the repository at this point in the history
Using  instead of  for error printing in kernel development ensures that error messages receive higher visibility and priority, aiding in identifying critical issues amidst a large volume of log messages. This practice enhances debugging efficiency, system stability, and maintains consistency across the codebase, contributing to more robust and reliable kernel implementations.
  • Loading branch information
ruck314 committed Feb 22, 2024
1 parent 376b24c commit cf50f2a
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions data_dev/driver/src/data_dev_top.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ int32_t DataDev_Init(void) {

/* Register PCI driver */
ret = pci_register_driver(&DataDevDriver);
if (probeReturn != 0)
{
if (probeReturn != 0) {
pr_err("%s: Init: failure detected in init. Unregistering driver.\n", MOD_NAME);
pci_unregister_driver(&DataDevDriver);
return probeReturn;
Expand Down Expand Up @@ -156,7 +155,7 @@ int DataDev_Probe(struct pci_dev *pcidev, const struct pci_device_id *dev_id) {
struct AxisG2Data *hwData;

if ( cfgMode != BUFF_COHERENT && cfgMode != BUFF_STREAM ) {
pr_warn("%s: Probe: Invalid buffer mode = %i.\n",MOD_NAME,cfgMode);
pr_err("%s: Probe: Invalid buffer mode = %i.\n", MOD_NAME, cfgMode);
return -EINVAL; // Return directly with an error code
}

Expand All @@ -178,7 +177,7 @@ int DataDev_Probe(struct pci_dev *pcidev, const struct pci_device_id *dev_id) {

// Overflow
if (id->driver_data < 0) {
pr_warn("%s: Probe: Too Many Devices.\n",MOD_NAME);
pr_err("%s: Probe: Too Many Devices.\n", MOD_NAME);
return -ENOMEM; // Return directly with an error code
}
dev = &gDmaDevices[id->driver_data];
Expand All @@ -190,8 +189,8 @@ int DataDev_Probe(struct pci_dev *pcidev, const struct pci_device_id *dev_id) {
// Enable the device
ret = pci_enable_device(pcidev);
if (ret) {
pr_warn("%s: Probe: pci_enable_device() = %i.\n",MOD_NAME,ret);
return ret; // Return with error code
pr_err("%s: Probe: pci_enable_device() = %i.\n", MOD_NAME, ret);
return ret; // Return with error code
}
pci_set_master(pcidev);

Expand Down

0 comments on commit cf50f2a

Please sign in to comment.