Exposing the DMA's GIT Version and API Version to pyrogue variables #1003
+234
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding DMA_Get_GITV/DMA_Get_Version to expose DMA's API/GIT version to userspace
|
@slacrherbst ae21150 has the update you requested during yesterday's rogue meeting |
ruck314
commented
May 30, 2024
| // Result may be that rawBuff = NULL | ||
| // Should this just be a warning? | ||
| ret->rawBuff = dmaMapDma(ret->fd, &(ret->bCount), &(ret->bSize)); | ||
| if (ret->rawBuff == NULL) { | ||
| ret->bCount = ioctl(ret->fd, DMA_Get_Buff_Count, 0); | ||
| ret->bCount = dmaGetBuffCount(ret->fd); |
There was a problem hiding this comment.
@slacrherbst Was there a "performance" reason why you were using a ioctl() in the AxiStreamDma.cpp code (instead of the header's API functions) here? If yes, I will change it back
slacrherbst
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description