Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Undone) Fix nodeList method in Node and add global node count tracking #982

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

slacrherbst
Copy link
Contributor

Fixes the Node method nodeList which was broken.

Also adds a class counter for Node to determine how many nodes exist in the system as a scaling metric.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (64ac9ce) 30.02% compared to head (e88b7e4) 30.06%.

Files Patch % Lines
python/pyrogue/_Node.py 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   30.02%   30.06%   +0.03%     
==========================================
  Files          65       65              
  Lines        6634     6639       +5     
  Branches     1013     1013              
==========================================
+ Hits         1992     1996       +4     
- Misses       4485     4486       +1     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bengineerd bengineerd merged commit e5e0b3c into main Jan 11, 2024
5 checks passed
@ruck314 ruck314 mentioned this pull request Jan 11, 2024
@bengineerd bengineerd changed the title Fix nodeList method in Node and add global node count tracking (Undone) Fix nodeList method in Node and add global node count tracking Jan 11, 2024
@bengineerd
Copy link
Contributor

This was mistakenly pushed to main instead of pre-release, then undone with a force push.
New PR is #983

@slacrherbst slacrherbst deleted the node_count branch April 1, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants