Fix suggested default address. Fix broken address/port lookup #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## pre-release #985 +/- ##
===============================================
+ Coverage 29.55% 30.04% +0.48%
===============================================
Files 65 65
Lines 6641 6644 +3
Branches 1014 1015 +1
===============================================
+ Hits 1963 1996 +33
+ Misses 4524 4491 -33
- Partials 154 157 +3 ☔ View full report in Codecov by Sentry. |
ruck314
added a commit
to slaclab/kek-bpm-rfsoc-dev
that referenced
this pull request
Feb 7, 2024
ruck314
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Confirmed that this change works and compatible with my v6.1.1 build:
slaclab/kek-bpm-rfsoc-dev@fab69be
ruck314
added a commit
to slaclab/warm-tdm
that referenced
this pull request
Feb 9, 2024
### Description - slaclab/rogue#985
ruck314
added a commit
to slaclab/surf
that referenced
this pull request
Feb 14, 2024
ruck314
added a commit
that referenced
this pull request
Feb 27, 2024
…Server listen address. This will avoid getting annoying messages from cyber security port scanners. Related to #985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation to suggest using 127.0.0.1 for the zmqServer listen address. This will avoid getting annoying messages from cyber security port scanners.
We still need to properly document ZmqServer to explain the various addr arg options.
I also fixed a bug where the address lookup always returns localhost, which will break the gui when users define options other than * or 127.0.0.1