Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable wait to allow for triggering on any update #994

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

slacrherbst
Copy link
Contributor

This adds an update flag to the local VariableValue class used in the variable wait lambda function. This allows VariableWait to stall on an update of a variable without caring about a particular value. This is useful for variables which are updated on data reception.

This also updates the incorrect documentation and code comments.

The Advance function is removed from the Process class and the default example loop updates are fixed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 30.04%. Comparing base (04d1e8a) to head (30e158f).
Report is 13 commits behind head on pre-release.

Files Patch % Lines
python/pyrogue/_Process.py 0.00% 2 Missing ⚠️
python/pyrogue/_Variable.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           pre-release     #994   +/-   ##
============================================
  Coverage        30.04%   30.04%           
============================================
  Files               65       65           
  Lines             6644     6644           
  Branches          1015     1015           
============================================
  Hits              1996     1996           
  Misses            4491     4491           
  Partials           157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bengineerd bengineerd merged commit a2687d0 into pre-release Mar 26, 2024
5 checks passed
@bengineerd bengineerd deleted the variable_wait branch March 26, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants