Add json converter for skiffs

sliekens · Jan 26, 2025 · 37c3081 · 37c3081
1 parent efc00df
commit 37c3081
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 2 deletions.
diff --git a/GW2SDK.Tests/Features/Hero/Equipment/Skiffs/SkiffSkins.cs b/GW2SDK.Tests/Features/Hero/Equipment/Skiffs/SkiffSkins.cs
@@ -1,4 +1,6 @@
-using GuildWars2.Tests.TestInfrastructure;
+using System.Text.Json;
+using GuildWars2.Hero.Equipment.Skiffs;
+using GuildWars2.Tests.TestInfrastructure;
 
 namespace GuildWars2.Tests.Features.Hero.Equipment.Skiffs;
 
@@ -24,6 +26,18 @@ public async Task Can_be_listed()
                 Assert.NotEmpty(entry.Name);
                 Assert.NotEmpty(entry.IconHref);
                 Assert.NotNull(entry.DyeSlots);
+                Assert.All(
+                    entry.DyeSlots,
+                    dyeSlot =>
+                    {
+                        Assert.True(dyeSlot.Material.IsDefined());
+                        Assert.True(dyeSlot.ColorId > 0);
+                    }
+                );
+
+                var json = JsonSerializer.Serialize(entry);
+                var roundtrip = JsonSerializer.Deserialize<SkiffSkin>(json);
+                Assert.Equal(entry, roundtrip);
             }
         );
     }

diff --git a/GW2SDK/Features/Hero/Equipment/Skiffs/SkiffSkin.cs b/GW2SDK/Features/Hero/Equipment/Skiffs/SkiffSkin.cs
@@ -1,8 +1,11 @@
-namespace GuildWars2.Hero.Equipment.Skiffs;
+using System.Text.Json.Serialization;
+
+namespace GuildWars2.Hero.Equipment.Skiffs;
 
 /// <summary>Information about a skiff skin.</summary>
 [PublicAPI]
 [DataTransferObject]
+[JsonConverter(typeof(SkiffSkinJsonConverter))]
 public sealed record SkiffSkin
 {
     /// <summary>The skiff skin ID.</summary>

diff --git a/GW2SDK/Features/Hero/Equipment/Skiffs/SkiffSkinJsonConverter.cs b/GW2SDK/Features/Hero/Equipment/Skiffs/SkiffSkinJsonConverter.cs
@@ -0,0 +1,40 @@
+using System.Text.Json;
+using System.Text.Json.Serialization;
+using GuildWars2.Json;
+
+namespace GuildWars2.Hero.Equipment.Skiffs;
+
+internal sealed class SkiffSkinJsonConverter : JsonConverter<SkiffSkin>
+{
+    public override SkiffSkin? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+    {
+        using var json = JsonDocument.ParseValue(ref reader);
+        return Read(json.RootElement);
+    }
+
+    public static SkiffSkin Read(JsonElement json)
+    {
+        return new SkiffSkin
+        {
+            Id = json.GetProperty("id").GetInt32(),
+            Name = json.GetProperty("name").GetStringRequired(),
+            IconHref = json.GetProperty("icon").GetStringRequired(),
+            DyeSlots = json.GetProperty("dye_slots").GetList(DyeSlotJsonConverter.Read)!
+        };
+    }
+
+    public override void Write(Utf8JsonWriter writer, SkiffSkin value, JsonSerializerOptions options)
+    {
+        writer.WriteStartObject();
+        writer.WriteNumber("id", value.Id);
+        writer.WriteString("name", value.Name);
+        writer.WriteString("icon", value.IconHref);
+        writer.WriteStartArray("dye_slots");
+        foreach (var dyeSlot in value.DyeSlots)
+        {
+            DyeSlotJsonConverter.Write(writer, dyeSlot);
+        }
+        writer.WriteEndArray();
+        writer.WriteEndObject();
+    }
+}