Add todo

sliekens · Jan 26, 2025 · ebc9b65 · ebc9b65
1 parent b78d3a2
commit ebc9b65
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/GW2SDK/Features/Hero/StoryJournal/Stories/Storyline.cs b/GW2SDK/Features/Hero/StoryJournal/Stories/Storyline.cs
@@ -14,6 +14,7 @@ public sealed record Storyline
     /// <summary>The display order of the storyline in the story journal.</summary>
     public required int Order { get; init; }
 
+    // TODO: should have been IReadOnlyList<int>
     /// <summary>The IDs of the stories that belong to this storyline.</summary>
     public required List<int> StoryIds { get; init; }
 }
diff --git a/GW2SDK/Features/Hero/StoryJournal/Stories/StorylineJson.cs b/GW2SDK/Features/Hero/StoryJournal/Stories/StorylineJson.cs
@@ -41,9 +41,11 @@ public static Storyline GetStoryline(this JsonElement json)
             Id = id.Map(static value => value.GetStringRequired()),
             Name = name.Map(static value => value.GetStringRequired()),
             Order = order.Map(static value => value.GetInt32()),
+
+            // TODO: should have been IReadOnlyList<int>
             StoryIds = stories.Map(
                 static values => values.GetList(static value => value.GetInt32())
-            )
+            ).ToList()
         };
     }
 }