Skip to content

Commit

Permalink
Merge pull request #557 from slovensko-digital/GO-170/log_more_data
Browse files Browse the repository at this point in the history
GO-170 Update error logging in Upvs::SubmitMessageDraftJob
  • Loading branch information
luciajanikova authored Feb 27, 2025
2 parents 8fbf499 + ec023b9 commit 68515d5
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions app/jobs/govbox/submit_message_draft_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def perform(message_draft, bulk_submit: false, upvs_client: UpvsEnvironment.upvs
message_draft.submitted!
Govbox::SyncBoxJob.set(wait: 3.minutes).perform_later(box) unless bulk_submit
else
handle_submit_fail(message_draft, response_status, response_body.dig("message"))
handle_submit_fail(message_draft, response_status, response_body)
end
end

Expand All @@ -81,7 +81,7 @@ def build_objects(message_draft)
objects
end

def handle_submit_fail(message_draft, response_status, response_message)
def handle_submit_fail(message_draft, response_status, response_body)
# TODO notification
message_draft.add_cascading_tag(message_draft.tenant.submission_error_tag)

Expand All @@ -90,12 +90,16 @@ def handle_submit_fail(message_draft, response_status, response_message)
message_draft.metadata["status"] = "temporary_submit_fail"
message_draft.save

raise TemporarySubmissionError, "Message #{message_draft.uuid}: #{response_status}, #{response_message}"
raise TemporarySubmissionError, error_message(message_draft, response_status, response_body)
else
message_draft.metadata["status"] = "submit_fail"
message_draft.save

raise SubmissionError, "Message #{message_draft.uuid}: #{response_status}, #{response_message}"
raise SubmissionError, error_message(message_draft, response_status, response_body)
end
end

def error_message(message_draft, response_status, response_body)
"Box #{message_draft.box.id}, Message #{message_draft.uuid}: #{response_status}, #{response_body}"
end
end

0 comments on commit 68515d5

Please sign in to comment.