Allow to use private IdPs with the OIDC provisioner #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows using the OIDC provisioner with private identity providers using a certificate from step-ca. Fixes #1909
github-actions
bot
added
the
needs triage
dopey
approved these changes
Jul 25, 2024
|
Merged this, as it was previously approved, and should go into the next release. |
hslatman
reviewed
Aug 13, 2024
| pool.AddCert(crt) | ||
| } | ||
|
|
||
| tr, ok := http.DefaultTransport.(*http.Transport) |
There was a problem hiding this comment.
This could turn out to be problematic in certain cases. We can follow up with a fix if so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the OIDC provisioner to be used with private identity providers using a certificate from step-ca.
Fixes #1909
cc: @tashian