Merge consecutive message requests together. #471
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoliman92
reviewed
Jan 20, 2025
| for i, report := range reports { | ||
| if i == 0 { | ||
| // initialize | ||
| seqRange = cciptypes.NewSeqNumRange(report.SequenceNumberRange.Start(), report.SequenceNumberRange.End()) | ||
| seqRange.SeqNumRange = cciptypes.NewSeqNumRange(report.SequenceNumberRange.Start(), report.SequenceNumberRange.End()) | ||
| seqRange.reports = []exectypes.CommitData{report} | ||
| } else if seqRange.End()+1 == report.SequenceNumberRange.Start() { | ||
| // extend the contiguous range | ||
| seqRange.SetEnd(report.SequenceNumberRange.End()) |
There was a problem hiding this comment.
Should we append the report to reports slice here?
asoliman92
reviewed
Jan 20, 2025
| lggr.Errorw("unable to read all messages for report", | ||
| "srcChain", srcChain, | ||
| "seqRange", report.SequenceNumberRange, | ||
| "merkleRoot", report.MerkleRoot, | ||
| "seqRange", seqNumRange, |
There was a problem hiding this comment.
Is it better to have the range for each report separately at this stage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds message request batching back to the exec GetMessages phase. This optimization was previously removed in #441 while improving the error handling behavior.