Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: timelock preloading ops authority #474

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

jadepark-dev
Copy link
Contributor

@jadepark-dev jadepark-dev commented Jan 19, 2025

Primary Changes

Preloading operation authority update

  • Updated access control macro to support multiple roles (OR condition) for authorization
  • Added role validation requirements for timelock operations (initialize/append/finalize/clear) to require proposer/bypasser or admin role
  • Enhanced operation preloading utilities to validate role access controller states
    • Added role access controller validation for timelock operation initialization and management
    • Modified instruction accounts to include role access controller validation

Bypasser execute operation management

  • Closes the operation PDA used in bypasser_execute_batch after execution

Others

  • Added role access controller checks in test suites for proper role validation
  • Updated operation preloading utilities to validate role access
  • Enhanced test coverage for unauthorized access scenarios (preload operation instructions + schedule in single mcm root)
  • Updated test utilities to include role access validation in operation preloading

@jadepark-dev jadepark-dev changed the title Solana/timelock preload op auth solana: proposer role as timelock preloading ops authority Jan 19, 2025
@jadepark-dev jadepark-dev self-assigned this Jan 20, 2025
@jadepark-dev jadepark-dev marked this pull request as ready for review January 20, 2025 05:25
@jadepark-dev jadepark-dev requested a review from a team as a code owner January 20, 2025 05:25
@jadepark-dev jadepark-dev marked this pull request as draft January 21, 2025 05:07
@jadepark-dev jadepark-dev changed the title solana: proposer role as timelock preloading ops authority solana: timelock preloading ops authority Jan 21, 2025
Copy link

Metric solana/timelock-preload-op-auth main
Coverage 76.8% 76.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant