Config cache #551
Merged
Config cache #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnogo
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
winder
reviewed
Feb 5, 2025
winder
reviewed
Feb 5, 2025
asoliman92
reviewed
Feb 10, 2025
asoliman92
reviewed
Feb 10, 2025
asoliman92
reviewed
Feb 10, 2025
asoliman92
reviewed
Feb 10, 2025
| ) | ||
|
|
||
| return contractreader.ExtendedBatchGetLatestValuesRequest{ | ||
| consts.ContractNameOffRamp: { |
There was a problem hiding this comment.
worth adding some warning comment that changing the order will fail the processing function. I suggest adding some unit test to make sure that the order doesn't change as well.
There was a problem hiding this comment.
The order here is not important. The processing is happening in a for loop with a switch statement. So even if the order changes, we would still be able to process the batched result correctly.
mateusz-sekara
approved these changes
Feb 11, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the CCIPChainReader to use a cache layer for static configuration data. Instead of making contract calls for each configuration request, static data like offramp config, RMN config, and fee quoter config is now cached with a configurable refresh period.
The
OnRampGetDynamicConfigandOnRampGetDestChainConfigare called from the src chain, so cannot be batched. We can eventually cache them (probably in an upcoming PR).