-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-5216 Tracking latencies and simplification in the metrics code #598
Conversation
processorLabel = "merkleroot" | ||
rootsLabel = "roots" | ||
messagesLabel = "messages" | ||
rmnSignatureLabel = "rmnSignatures" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the rootsLabel, messagesLabel, rmnSignatureLabel under the processorLabel? Meaning all the 3 labels will be dimensions of merkleroot metric?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the question (btw these labels were there before, I'm only moving them from one place to another)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure we track durations for individual processor states.
E.g.
labels = {
"plugin": "commit",
"processor": "merkleRoots",
"phase": "observation",
"state": "buildingReport",
"duration": x
}
labels = {
"plugin": "exec",
"phase": "observation",
"state": "filtering"
"duration": x
}
It is also useful to track the oracleID
in this metrics.
Sometimes maybe a specific oracle has issues that contribute to high P99,P90 because the RPC they are using is slow.
These are tracked automatically |
|
Simplifying tracking metrics for the processors by:
TrackedProcessor
), so plugin is less polluted with the observability stuffAdditionally, tracking errors and latencies for the processor methods