-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1936] Seth with simulated backend #1593
Open
Tofel
wants to merge
6
commits into
main
Choose a base branch
from
tt-1936-seth-simulated-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,247
−404
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
891897a
PoC of using Simulated Backend with Seth
Tofel ae186e7
add support for passing custom ethclient to Seth (including Simulated…
Tofel e6d9102
Merge remote-tracking branch 'origin/main' into tt-1936-seth-simulate…
Tofel b24071f
Merge branch 'main' into tt-1936-seth-simulated-backend
Tofel 4af5ca6
Merge branch 'main' into tt-1936-seth-simulated-backend
Tofel 26e32d4
disable eip1559 for Geth
Tofel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it replace the
ethclient.Client
completely? In the dev-platform CLI we're usingseth.Client
also in the production environment. Our question and request was to be able to swap the real client with a simualted one, so in unit/isolated tests we don't need to interact with Anvil (or similar), but rather in-memory simulated backend.Here's example how we're constructing
seth.Client
: https://github.com/smartcontractkit/dev-platform/blob/main/cmd/client/eth_client.go#L94And here's example how it's used to interact with capabilities registry contract: https://github.com/smartcontractkit/dev-platform/blob/main/cmd/client/capabilities_registry_client.go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't.
simulated.Client
is just an interface, you can pass*ethclient.Client
assimulated.Client
. Anyway, this only applies if you pass simulated backed explicitly to the builder like thisWithEthClient(backend.Client()).
. Otherwise it will use the URL provided and start a normal client.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for clarification 🙇