Implement `set-channel-definitions` for ChannelConfigStore. #16101

ro-tex · 2025-01-28T15:02:26Z

Rename deployment/llo to deployment/data-stream in order to avoid confusion.
Update the implementation to match current conventions.
Implement a setChannelDefinitions method call on the ChannelConfigStore contract.

Requires

Supports

github-actions · 2025-01-28T15:23:18Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

github-actions · 2025-02-06T16:40:41Z

Flakeguard Summary

Ran new or updated tests between develop and eb25bcf (ivo/impl-set-channel-definitions).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestCallSetChannelDefinitions	0.00%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/deployment/data-streams/changeset	false	1.053333333s	@AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions · 2025-02-06T17:26:20Z

Flakeguard Summary

Ran new or updated tests between develop and dd2dcbd (ivo/impl-set-channel-definitions).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestCallSetChannelDefinitions	0.00%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/deployment/data-streams/changeset	false	1.056666666s	@AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions · 2025-02-07T11:11:25Z

Flakeguard Summary

Ran new or updated tests between develop and 45eed65 (ivo/impl-set-channel-definitions).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestCallSetChannelDefinitions	0.00%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/deployment/data-streams/changeset	false	1.04s	@AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

krehermann · 2025-02-07T15:23:41Z

deployment/data-streams/changeset/call_set_channel_definitions.go

+	SetChannelDefinitionsConfig struct {
+		// DefinitionsByChain is a map of chain selectors -> ChannelConfigStore addresses -> ChannelDefinitions to deploy.
+		DefinitionsByChain map[uint64]map[string]ChannelDefinition // Use string for address because of future non-EVM chains.
+		MCMSConfig         *MCMSConfig


@akhilchainani @ecPablo is there a common, canonical configuration struct that can be used here?

ccip, keystone and streams are all defining their own

I think we don't have one yet. But all the types look very similar, we should just pick one and move it to https://github.com/smartcontractkit/chainlink/blob/develop/deployment/common/types/types.go

ChrisAmora · 2025-02-25T14:25:46Z

.gitignore

@@ -116,4 +116,5 @@ vendor/*

 *.wasm
 contracts/lcov.info
+contracts/out/


Why do we need this?

This is the output directory for compiling contracts. If you want to have the compiled artifacts locally, they will be in that location and git will show them to you as uncommitted new files. I ignored it, so I can keep the artifacts without being bugged about them and without any risk to accidentally committing them.

ecPablo · 2025-02-25T21:02:50Z

deployment/data-streams/changeset/call_set_channel_definitions.go

+	SetChannelDefinitionsConfig struct {
+		// DefinitionsByChain is a map of chain selectors -> ChannelConfigStore addresses -> ChannelDefinitions to deploy.
+		DefinitionsByChain map[uint64]map[string]ChannelDefinition // Use string for address because of future non-EVM chains.
+		MCMSConfig         *MCMSConfig


I think we don't have one yet. But all the types look very similar, we should just pick one and move it to https://github.com/smartcontractkit/chainlink/blob/develop/deployment/common/types/types.go

cl-sonarqube-production · 2025-02-26T09:48:50Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

akuzni2 · 2025-02-26T17:20:25Z

deployment/common/types/types.go

@@ -44,6 +44,8 @@ const (
 	ExecutorAccessControllerAccount  deployment.ContractType = "ExecutorAccessControllerAccount"
 	CancellerAccessControllerAccount deployment.ContractType = "CancellerAccessControllerAccount"
 	BypasserAccessControllerAccount  deployment.ContractType = "BypasserAccessControllerAccount"
+	// Data Streams contracts
+	ChannelConfigStore deployment.ContractType = "ChannelConfigStore"


Should this be defined in this high level types? Or can it be kept in a data-streams type section?

akuzni2 · 2025-02-26T17:27:08Z

@ro-tex should all or some changesets be organized into contract/version subdirectory?
For example set setChannelDefinitions could differ on this version to the next version and we need a way to distinguish them. Same with the remaining contracts verifier, reward manager, etc... have differing versions during configuration. Deployment itself may be version agnostic.

Freshen up deploymeny/llo.

7fb880f

ro-tex added the wip label Jan 28, 2025

ro-tex added 6 commits January 28, 2025 17:35

Rename deployment/llo to deployment/data-streams.

c6ea6bb

Reorg changeset code.

f6af0a1

Remove debug.

634f386

Implement setChannelDefinitions on ChannelConfigStore.

7c65dbe

Merge branch 'develop' into ivo/impl-set-channel-definitions

45173b0

Add a test.

eb25bcf

ro-tex removed the wip label Feb 6, 2025

ro-tex added 2 commits February 6, 2025 17:46

Fix lint.

f12c247

Fix lint.

dd2dcbd

Fix test.

45eed65

Update unit test.

2926e93

ro-tex marked this pull request as ready for review February 7, 2025 13:49

ro-tex requested review from a team as code owners February 7, 2025 13:49

ro-tex requested review from winder, asoliman92, makramkd, dimkouv, mateusz-sekara and 0xAustinWang February 7, 2025 13:49

ro-tex requested review from 0xnogo and krehermann February 7, 2025 13:49

krehermann reviewed Feb 7, 2025

View reviewed changes

ChrisAmora mentioned this pull request Feb 10, 2025

feat: add jd initial register changeset #16307

Merged

Merge branch 'develop' into ivo/impl-set-channel-definitions

806f09c

ChrisAmora previously approved these changes Feb 25, 2025

View reviewed changes

ecPablo previously approved these changes Feb 25, 2025

View reviewed changes

ro-tex requested a review from krehermann February 26, 2025 09:24

Make Data Streams engineers code owners for their CLD code.

39713d5

ro-tex dismissed stale reviews from ecPablo and ChrisAmora via 39713d5 February 26, 2025 09:33

ro-tex requested review from ecPablo and ChrisAmora February 26, 2025 09:35

akuzni2 reviewed Feb 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `set-channel-definitions` for ChannelConfigStore. #16101

Implement `set-channel-definitions` for ChannelConfigStore. #16101

ro-tex commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 7, 2025

krehermann Feb 7, 2025

ecPablo Feb 25, 2025

ChrisAmora Feb 25, 2025

ro-tex Feb 26, 2025

ecPablo Feb 25, 2025

cl-sonarqube-production bot commented Feb 26, 2025

akuzni2 Feb 26, 2025

akuzni2 commented Feb 26, 2025

Implement set-channel-definitions for ChannelConfigStore. #16101

Are you sure you want to change the base?

Implement set-channel-definitions for ChannelConfigStore. #16101

Conversation

ro-tex commented Jan 28, 2025 • edited Loading

Requires

Supports

github-actions bot commented Jan 28, 2025 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

github-actions bot commented Feb 6, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

github-actions bot commented Feb 6, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

github-actions bot commented Feb 7, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

krehermann Feb 7, 2025

Choose a reason for hiding this comment

ecPablo Feb 25, 2025

Choose a reason for hiding this comment

ChrisAmora Feb 25, 2025

Choose a reason for hiding this comment

ro-tex Feb 26, 2025

Choose a reason for hiding this comment

ecPablo Feb 25, 2025

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Feb 26, 2025

Quality Gate passed

akuzni2 Feb 26, 2025

Choose a reason for hiding this comment

akuzni2 commented Feb 26, 2025

Implement `set-channel-definitions` for ChannelConfigStore. #16101

Implement `set-channel-definitions` for ChannelConfigStore. #16101

ro-tex commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading