Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1608] Utilize Parrot #16574

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

[TT-1608] Utilize Parrot #16574

wants to merge 8 commits into from

Conversation

kalverra
Copy link
Collaborator

Marks previous mock adapter approaches of Killgrave and Mockserver as deprecated and uses Parrot instead for simplicity and compatibility.

Copy link
Contributor

github-actions bot commented Feb 25, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , test-scripts , Core Tests (go_core_race_tests) , SonarQube Scan , lint

1. GolangCI Lint job failed: Check Golangci-lint Matrix Results

Source of Error:
Check Golangci-lint Matrix Results	2025-02-25T22:22:05.0813328Z ##[error]Process completed with exit code 1.
**Why**: The GolangCI Lint job failed due to linting errors in the codebase, which caused the process to exit with code 1.

Suggested fix: Review and fix the linting errors reported by GolangCI Lint in the codebase to ensure compliance with the linting rules.

2. Integer overflow conversion error: Golang Lint (integration-tests)

Source of Error:
Golang Lint (integration-tests)	2025-02-25T22:21:49.1717579Z ##[error]integration-tests/smoke/forwarders_ocr2_test.go:136:9: G115: integer overflow conversion int64 -> uint64 (gosec)
Golang Lint (integration-tests)	2025-02-25T22:21:49.1720588Z ##[error]integration-tests/smoke/ocr2_test.go:156:9: G115: integer overflow conversion int64 -> uint64 (gosec)
Golang Lint (integration-tests)	2025-02-25T22:21:49.1722924Z ##[error]integration-tests/smoke/ocr2_test.go:244:9: G115: integer overflow conversion int64 -> uint64 (gosec)
**Why**: The code contains instances where an `int64` value is being converted to `uint64`, which can lead to integer overflow issues.

Suggested fix: Ensure that the values being converted from int64 to uint64 are within the valid range for uint64 or refactor the code to avoid such conversions.

3. Unnecessary conversion error: Golang Lint (integration-tests)

Source of Error:
Golang Lint (integration-tests)	2025-02-25T22:21:49.1725272Z ##[error]integration-tests/smoke/forwarders_ocr2_test.go:159:17: unnecessary conversion (unconvert)
**Why**: The code contains an unnecessary type conversion that can be removed to simplify the code.

Suggested fix: Remove the unnecessary type conversion to clean up the code.

4. String concatenation optimization: Golang Lint (integration-tests)

Source of Error:
Golang Lint (integration-tests)	2025-02-25T22:21:49.1728051Z ##[error]integration-tests/actions/ocr_helpers_local.go:128:23: fmt.Sprintf can be replaced with string concatenation (perfsprint)
Golang Lint (integration-tests)	2025-02-25T22:21:49.1734093Z ##[error]integration-tests/ccip-tests/actions/ccip_helpers.go:4883:25: fmt.Sprintf can be replaced with string concatenation (perfsprint)
**Why**: The `fmt.Sprintf` function is used where simple string concatenation would be more efficient.

Suggested fix: Replace fmt.Sprintf with string concatenation for better performance.

5. Error creation optimization: Golang Lint (integration-tests)

Source of Error:
Golang Lint (integration-tests)	2025-02-25T22:21:49.1730999Z ##[error]integration-tests/ccip-tests/actions/ccip_helpers.go:4811:10: fmt.Errorf can be replaced with errors.New (perfsprint)
**Why**: The `fmt.Errorf` function is used to create a static error message, which can be replaced with `errors.New` for simplicity.

Suggested fix: Replace fmt.Errorf with errors.New for static error messages.

6. Unnecessary fmt.Sprintf in require.Equal: Golang Lint (integration-tests)

Source of Error:
Golang Lint (integration-tests)	2025-02-25T22:21:49.1737082Z ##[error]integration-tests/smoke/forwarders_ocr2_test.go:164:3: formatter: remove unnecessary fmt.Sprintf (testifylint)
**Why**: The `fmt.Sprintf` function is used unnecessarily within a `require.Equal` assertion.

Suggested fix: Remove the fmt.Sprintf call and use the values directly in the require.Equal assertion.

7. Go module updates needed: Clean Go Tidy & Generate

Source of Error:
make generate	2025-02-25T22:24:54.6175845Z 	go: updates to go.mod needed; to update it:
make generate	2025-02-25T22:24:54.6175934Z 		go mod tidy
make generate	2025-02-25T22:24:54.6176028Z 	error: exit status 1
make generate	2025-02-25T22:24:54.6183150Z ##[error]Process completed with exit code 2.
**Why**: The Go modules require updates, and the `go mod tidy` command needs to be run to update the `go.mod` file.

Suggested fix: Run go mod tidy to update the go.mod file and ensure all dependencies are correctly listed.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant