Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename EVMExtraArgsV2 to GenericExtraArgsV2 #16584

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Feb 26, 2025

Renames EVMExtraArgsV2 to GenericExtraArgsV2. This change DOES NOT change the bytecode for any contract except the offchain-helper message_hasher.

@RensR RensR requested a review from a team as a code owner February 26, 2025 10:45
Copy link
Contributor

github-actions bot commented Feb 26, 2025

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/early-pumas-design.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

Copy link
Contributor

Static analysis results are available

Hey @RensR, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@@ -32,7 +32,7 @@ type ClientEVMExtraArgsV1 struct {
GasLimit *big.Int
}

type ClientEVMExtraArgsV2 struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old name ClientEVMExtraArgsV2 is still referenced in some tests inside the ccip.ccipevm package.
They too need to change to this new name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants