Don't error if device switched off #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like my change breaks things, will debug tomorrow. |
Previously get_device or the related functions would retrieve a list of devices that it contacted in the last x seconds. Then we would contact each light in turn to try and apply some sort of filtering. This would error out if the light had been switched off. This patch attempts to contact each light and skips it if it cannot be contacted. This also caches the label of the light so we can display the repr string even if the light is offline. Closes smarthall#6
|
Have updated the patch. Can't use filter as the name of the parameter, as it overrides the Python filter function. |
If IP Address has changed for the light, make sure we use the new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously get_device or the related functions would retrieve a list of
devices that it contacted in the last x seconds. Then we would contact
each light in turn to try and apply some sort of filtering.
This would error out if the light had been switched off.
This patch attempts to contact each light and skips it if it cannot be
contacted.
Closes #6
Note: I haven't tested this latest version just yet. The previous version, which was similar worked fine. Will do that ASAP.