Low-hanging perf improvements in highlighting code #416
pull-request.yaml
on: pull_request
lint-test-danger
1m 16s
Annotations
3 errors and 1 warning
getRequestHighlightFields() › should generate highlight_query with group fields replaced:
packages/provider-elasticsearch/src/example-types/results/highlighting/request.js#L154
TypeError: r.push is not a function
at Module._ (node_modules/futil/lib/webpack:/futil/src/array.js:67:24)
at n (node_modules/lodash/lodash.min.js:9:117)
at Module.u (node_modules/lodash/lodash.min.js:56:63)
at pushOn (packages/provider-elasticsearch/src/example-types/results/highlighting/request.js:154:18)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:104:24)
at pre (node_modules/futil/lib/webpack:/futil/src/tree.js:37:18)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at node_modules/futil/lib/webpack:/futil/src/tree.js:114:3
at n (node_modules/lodash/lodash.min.js:9:151)
at u (node_modules/lodash/lodash.min.js:56:63)
at collectKeysAndValues (packages/provider-elasticsearch/src/example-types/results/highlighting/request.js:152:17)
at collectKeysAndValues (packages/provider-elasticsearch/src/example-types/results/highlighting/request.js:170:28)
at Object.getRequestHighlightFields (packages/provider-elasticsearch/src/example-types/results/highlighting/request.test.js:393:18)
|
getRequestHighlightFields() › should generate highlight_query with group fields replaced for sub fields:
packages/provider-elasticsearch/src/example-types/results/highlighting/request.js#L154
TypeError: r.push is not a function
at Module._ (node_modules/futil/lib/webpack:/futil/src/array.js:67:24)
at n (node_modules/lodash/lodash.min.js:9:117)
at Module.u (node_modules/lodash/lodash.min.js:56:63)
at pushOn (packages/provider-elasticsearch/src/example-types/results/highlighting/request.js:154:18)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:104:24)
at pre (node_modules/futil/lib/webpack:/futil/src/tree.js:37:18)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at r (node_modules/lodash/lodash.min.js:56:237)
at g (node_modules/lodash/lodash.min.js:11:415)
at ho (node_modules/lodash/lodash.min.js:77:27)
at node_modules/lodash/lodash.min.js:56:256
at l (node_modules/lodash/lodash.min.js:58:213)
at concat (node_modules/futil/lib/webpack:/futil/src/tree.js:37:34)
at node_modules/futil/lib/webpack:/futil/src/tree.js:114:3
at n (node_modules/lodash/lodash.min.js:9:151)
at u (node_modules/lodash/lodash.min.js:56:63)
at collectKeysAndValues (packages/provider-elasticsearch/src/example-types/results/highlighting/request.js:152:17)
at collectKeysAndValues (packages/provider-elasticsearch/src/example-types/results/highlighting/request.js:170:28)
at Object.getRequestHighlightFields (packages/provider-elasticsearch/src/example-types/results/highlighting/request.test.js:454:18)
|
lint-test-danger
Process completed with exit code 1.
|
lint-test-danger
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, wearerequired/lint-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|