Merge pull request #191 from smartprocure/feature/omit-empty-highligh…

…t-object Do not set empty highlights on hit if there are none
smartprocure · Jan 30, 2024 · bf256a1 · bf256a1
2 parents cc2955c + bb72745
commit bf256a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/eleven-bikes-pull.md b/.changeset/eleven-bikes-pull.md
@@ -0,0 +1,5 @@
+---
+'contexture-elasticsearch': patch
+---
+
+Do not set empty highlights on hit if there are none.
diff --git a/packages/provider-elasticsearch/src/example-types/results/highlighting/search.js b/packages/provider-elasticsearch/src/example-types/results/highlighting/search.js
@@ -49,7 +49,9 @@ export let searchWithHighlights = (node, search, schema) => async (body) => {
   )
 
   for (let hit of response.hits.hits) {
-    hit.highlight = getResponseHighlight(schema, hit, tags, nestedPathsMap)
+    if (hit.highlight) {
+      hit.highlight = getResponseHighlight(schema, hit, tags, nestedPathsMap)
+    }
     removePathsFromSource(schema, hit, addedPaths)
     mergeHighlightsOnSource(schema, hit)
   }