Allow dots in keywords when searching on exact words #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81f3102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
conraddavisjr
approved these changes
Mar 18, 2024
Co-authored-by: Conrad Davis Jr <[email protected]> Signed-off-by: Alejandro Hernandez <[email protected]>
| // words instead of their variations. | ||
| wordsMatchPattern = node.exact | ||
| ? alphaNumericRegExWithDots | ||
| : alphaNumericRegEx, |
There was a problem hiding this comment.
Why would we not always use alphaNumericRegExWithDots? Also, why are the regexs so strange looking?
There was a problem hiding this comment.
I thought that's we had agreed on, that if you didn't search for exact you'd get the current behavior?
I think they are strange looking because they were copied from lodash. See this comment
added 2 commits
March 19, 2024 14:29
…ure/contexture into feature/allow-dots-in-keywords
|
Coverage after merging feature/allow-dots-in-keywords into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow dots in keywords tags when matching on exact words
Screen.Recording.2024-03-15.at.1.52.40.PM.mov