Feature/rd registration #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Periodical update seems not to be triggered..
When the board starts it tries to register to a resource directory until the registering succeeds. After that an update request is sent to the resource directory periodically (period defined in Makefile). When the update fails only a message is printed so far because trying to register again like on boot seems not to work (I have to figure out what the issue is).
rosetree
requested changes
Dec 16, 2019
There was a problem hiding this comment.
Thank you, @MatthiasBraeuer – great work! It’s wonderful, that you documented your functions. I’m not sure how to test it, though :)
The requested changes are mostly 👾 whitespaces fixes. And maybe we could talk about how we deal with debug messages and prints…
| @@ -36,8 +55,13 @@ int main(void) | |||
|
|
|||
| msg_init_queue(_main_msg_queue, MAIN_QUEUE_SIZE); | |||
|
|
|||
| saul_cord_ep_register_cb(_on_ep_event); | |||
There was a problem hiding this comment.
Maybe we could just register this event handler, if (DEBUG).
There was a problem hiding this comment.
Since we want to make our project includeable as a module, I would keep it like this, because our main module would not be included in an application using our module.
Before `SAUL_CORD_EP_DEREGISTERED` was passed when registration succeeded and `SAUL_CORD_EP_REGISTERED` when registration failed. I switched it. Also cord ep dump is called outside of the register function now.
RIOT style guide says, that one indentation level must be 4 spaces.
rosetree
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It may be necessary to wait a certain time on startup until the board is fully configured (has non-tentative IPv6 address, ...), or better trigger registration as soon as the configuration is done (if it is somehow possible).
For more information check out issue #14.
Closes #14