SKS-1701: Filter ECP IP when using kubectl get elfmachine
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 55.71% 55.71%
=======================================
Files 16 16
Lines 2728 2728
=======================================
Hits 1520 1520
Misses 1073 1073
Partials 135 135 |
jessehu
reviewed
Aug 16, 2023
api/v1beta1/elfmachine_types.go
Outdated
| @@ -179,7 +179,7 @@ type ElfMachineStatus struct { | |||
| //+kubebuilder:subresource:status | |||
| //+kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.ready",description="ElfMachine ready status" | |||
| //+kubebuilder:printcolumn:name="ProviderID",type="string",JSONPath=".spec.providerID",description="ElfMachine instance ID" | |||
| //+kubebuilder:printcolumn:name="IP",type="string",JSONPath=".status.addresses[0].address",description="IP address of the first network device of the virtual machine" | |||
| //+kubebuilder:printcolumn:name="IP",type="string",JSONPath=".status.addresses[?(@.address!=\"240.255.0.1\")].address",description="IP address of one of the virtual machine's network devices" | |||
There was a problem hiding this comment.
改成："IP addresses of the virtual machine"
There was a problem hiding this comment.
PR中的测试结果并没有使用带filter的jsonpath
明白了，是有的。我补充下PR描述。
jessehu
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
通过 kubectl get elfmachine 的时候，会显示 ECP 的 fake IP.
解决
通过 JSONPath=".status.addresses[?(@.address!="240.255.0.1")].address 过滤 ECP IP，240.255.0.1 是 ECP 固定使用的 IP。
测试
kubectl get elfmachine
kubectl get elfmachine haijian-test3-controlplane-b7cwh -o=jsonpath="{.status.addresses[*].address}"
kubectl get elfmachine (默认使用修改过的CRD column定义，会将ecp fake IP过滤掉)
kubectl get elfmachine haijian-test3-controlplane-b7cwh -o=jsonpath="{.status.addresses[*].address}"
kubectl get elfmachine
kubectl get elfmachine haijian-test3-controlplane-b7cwh -o=jsonpath="{.status.addresses[*].address}"
