Skip to content

#65 handling utf8 input over stdin #236

#65 handling utf8 input over stdin

#65 handling utf8 input over stdin #236

GitHub Actions / clippy succeeded Jan 15, 2025 in 1s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check warning on line 122 in src/ziplist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

warning: this `match` expression can be replaced with `?`
   --> src/ziplist.rs:119:21
    |
119 |           let focus = match it.next() {
    |  _____________________^
120 | |             Some(t) => t,
121 | |             None => return None,
122 | |         };
    | |_________^ help: try instead: `it.next()?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
note: the lint level is defined here
   --> src/lib.rs:5:5
    |
5   |     clippy::style,
    |     ^^^^^^^^^^^^^
    = note: `#[warn(clippy::question_mark)]` implied by `#[warn(clippy::style)]`

Check warning on line 369 in src/fsys/buffer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

needless call to `as_bytes()`

warning: needless call to `as_bytes()`
   --> src/fsys/buffer.rs:369:24
    |
369 |         stat.n_bytes = content.as_bytes().len() as u64;
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `content.len()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
note: the lint level is defined here
   --> src/lib.rs:3:5
    |
3   |     clippy::complexity,
    |     ^^^^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::needless_as_bytes)]` implied by `#[warn(clippy::complexity)]`

Check warning on line 122 in src/ziplist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

warning: this `match` expression can be replaced with `?`
   --> src/ziplist.rs:119:21
    |
119 |           let focus = match it.next() {
    |  _____________________^
120 | |             Some(t) => t,
121 | |             None => return None,
122 | |         };
    | |_________^ help: try instead: `it.next()?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
note: the lint level is defined here
   --> src/lib.rs:5:5
    |
5   |     clippy::style,
    |     ^^^^^^^^^^^^^
    = note: `#[warn(clippy::question_mark)]` implied by `#[warn(clippy::style)]`

Check warning on line 369 in src/fsys/buffer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

needless call to `as_bytes()`

warning: needless call to `as_bytes()`
   --> src/fsys/buffer.rs:369:24
    |
369 |         stat.n_bytes = content.as_bytes().len() as u64;
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `content.len()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
note: the lint level is defined here
   --> src/lib.rs:3:5
    |
3   |     clippy::complexity,
    |     ^^^^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::needless_as_bytes)]` implied by `#[warn(clippy::complexity)]`

Check warning on line 827 in crates/ninep/src/server.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

warning: this `match` expression can be replaced with `?`
   --> crates/ninep/src/server.rs:824:42
    |
824 |                           let mut stream = match self.stream.try_clone() {
    |  __________________________________________^
825 | |                             Ok(stream) => stream,
826 | |                             Err(err) => return Err(err),
827 | |                         };
    | |_________________________^ help: try instead: `self.stream.try_clone()?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
note: the lint level is defined here
   --> crates/ninep/src/lib.rs:5:5
    |
5   |     clippy::style,
    |     ^^^^^^^^^^^^^
    = note: `#[warn(clippy::question_mark)]` implied by `#[warn(clippy::style)]`