Update to mzlib544 #137
Merged
Update to mzlib544 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
nbollis and
zhuoxinshi
|
Ran this version with the vignette data, the output looks fine, we get the expected results. However, the AllPeptides output still has an extra tab in the header. |
acesnik
approved these changes
Dec 11, 2023
nbollis
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full changelog for mzlib 544 can be found here:
smith-chem-wisc/mzLib@1.0.543...1.0.544
This PR fixes a bug in the output so that rows have the sample number of values as columns which can break certain downstream applications.
This PR addresses this issue: #134
Support for oligos in mzlib shouldn't change anything for FlashLFQ yet. But, we should plausibly be able to accommodate both peptides and oligos in some future incarnation.