Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerson silva filho - Adding support to "links" instead of "_links". #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GersonSilvaFilho
Copy link

No description provided.

Adding Link resolver with "links" search instead of "_links".
Adding new TraversonModifiedJsonHalLinkResolver option.
Correcting file name.
@GersonSilvaFilho GersonSilvaFilho changed the title Gerson silva filho patch 1 Gerson silva filho - Adding support to "links" instead of "_links". Aug 7, 2017
@vicmosin
Copy link
Member

vicmosin commented Aug 8, 2017

Hi @GersonSilvaFilho ,
many thanks for your PR but I believe this change is too private case and can be solved as a resolver extension in your local project.. HAL standard clearly defined the _links property.

@GersonSilvaFilho
Copy link
Author

GersonSilvaFilho commented Aug 8, 2017

Hi @vicmosin

Thanks for your reply =)

Yes at first i thought this was something really specific, that's why i added the name "TraversonModifiedJsonHalLinkResolver". Now i've found out that there is an specific protocol called Siren that follow same principles than HAL and don't use the underscore.

https://github.com/kevinswiber/siren

Actually the API that i'm using is following this pattern. Do you think that would be good to add it? I would correct the names to "TraversonSirenLinkResolver" and ".Siren"or something like that.

@vicmosin
Copy link
Member

vicmosin commented Aug 8, 2017

Sure. But please provide appropriate tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants