Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Banner and Cloud reads for Alias user #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Banner and Cloud reads for Alias user #285

wants to merge 1 commit into from

Conversation

ochan1
Copy link
Contributor

@ochan1 ochan1 commented May 4, 2021

No description provided.

@ochan1 ochan1 mentioned this pull request May 4, 2021
Open
@ochan1
Copy link
Contributor Author

ochan1 commented May 4, 2021

This Pull Request is in combination with 3 other Pull Requests

  1. Add Banner and Cloud reads for Alias user SnapSite#105 (SnapSite)
  2. Add Banner and Cloud reads for Alias user #285 (snapCloud)
  3. Alias Username fetch on CheckCredential calls jmoenig/Snap#2827 (Snap)

Please make sure all three are good at the same time and approve all three at the same time!

@ochan1 ochan1 mentioned this pull request May 4, 2021
Open
@cycomachead
Copy link
Member

I think this looks good. I'll test it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ochan1 @cycomachead