-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI housekeeping #303
Merged
Merged
CI housekeeping #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - bump Credo and related deps to resolve compilation errors - set minimum Elixir version to 1.13 due to Credo - specify versions as strings, not numbers - support Elixir 1.17/Erlang OTP 27 in CI matrix
kianmeng
commented
Feb 21, 2025
@@ -9,7 +9,7 @@ defmodule Finch.MixProject do | |||
[ | |||
app: :finch, | |||
version: @version, | |||
elixir: "~> 1.11", | |||
elixir: "~> 1.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: the dependency :hpax requires Elixir "~> 1.12" but you are running on v1.11.4
==> hpax
==> erlex
Compiling 2 files (.erl)
Compiling 1 file (.ex)
==> file_system
Compiling 7 files (.ex)
Generated file_system app
==> mint
warning: the dependency :mint requires Elixir "~> 1.12" but you are running on v1.11.4
Compiling 1 file (.erl)
Compiling 20 files (.ex)
===> Analyzing applications...
===> Compiling ranch
===> Analyzing applications...
===> Compiling telemetry
==> jason
Compiling [10](https://github.com/kianmeng/finch/actions/runs/13454347328/job/37594971440#step:11:11) files (.ex)
Generated jason app
==> credo
warning: the dependency :credo requires Elixir ">= 1.13.0" but you are running on v1.[11](https://github.com/kianmeng/finch/actions/runs/13454347328/job/37594971440#step:11:12).4
Compiling 251 files (.ex)
kianmeng
commented
Feb 21, 2025
@@ -4,14 +4,14 @@ | |||
"cowboy": {:hex, :cowboy, "2.10.0", "ff9ffeff91dae4ae270dd975642997afe2a1179d94b1887863e43f681a203e26", [:make, :rebar3], [{:cowlib, "2.12.1", [hex: :cowlib, repo: "hexpm", optional: false]}, {:ranch, "1.8.0", [hex: :ranch, repo: "hexpm", optional: false]}], "hexpm", "3afdccb7183cc6f143cb14d3cf51fa00e53db9ec80cdcd525482f5e99bc41d6b"}, | |||
"cowboy_telemetry": {:hex, :cowboy_telemetry, "0.4.0", "f239f68b588efa7707abce16a84d0d2acf3a0f50571f8bb7f56a15865aae820c", [:rebar3], [{:cowboy, "~> 2.7", [hex: :cowboy, repo: "hexpm", optional: false]}, {:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "7d98bac1ee4565d31b62d59f8823dfd8356a169e7fcbb83831b8a5397404c9de"}, | |||
"cowlib": {:hex, :cowlib, "2.12.1", "a9fa9a625f1d2025fe6b462cb865881329b5caff8f1854d1cbc9f9533f00e1e1", [:make, :rebar3], [], "hexpm", "163b73f6367a7341b33c794c4e88e7dbfe6498ac42dcd69ef44c5bc5507c8db0"}, | |||
"credo": {:hex, :credo, "1.7.3", "05bb11eaf2f2b8db370ecaa6a6bda2ec49b2acd5e0418bc106b73b07128c0436", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "35ea675a094c934c22fb1dca3696f3c31f2728ae6ef5a53b5d648c11180a4535"}, | |||
"credo": {:hex, :credo, "1.7.11", "d3e805f7ddf6c9c854fd36f089649d7cf6ba74c42bc3795d587814e3c9847102", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "56826b4306843253a66e47ae45e98e7d284ee1f95d53d1612bb483f88a8cf219"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: (credo 1.7.3) lib/credo/check/params.ex:39: Credo.Check.Params.get/3
(credo 1.7.3) lib/credo/check/params.ex:91: Credo.Check.Params.files_included/2
(credo 1.7.3) lib/credo/check/runner.ex:46: Credo.Check.Runner.do_run_check/2
(elixir 1.18.2) lib/task/supervised.ex:101: Task.Supervised.invoke_mfa/2
(elixir 1.18.2) lib/task/supervised.ex:36: Task.Supervised.reply/4
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/finch/error.ex
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/finch.ex
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/finch/http1/conn.ex
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/finch/http1/pool.ex
Error while running Elixir.Credo.Check.Readability.ParenthesesInCondition on lib/finch/error.ex
Error while running Elixir.Credo.Check.Readability.ParenthesesInCondition on lib/finch/http1/conn.ex
Error while running Elixir.Credo.Check.Readability.ParenthesesInCondition on lib/finch/http1/pool.ex
Error while running Elixir.Credo.Check.Readability.Semicolons on lib/finch/error.ex
Error while running Elixir.Credo.Check.Readability.ParenthesesInCondition on lib/finch.ex
Error while running Elixir.Credo.Check.Readability.Semicolons on lib/finch/http1/pool.ex
Error while running Elixir.Credo.Check.Readability.Semicolons on lib/finch/http1/conn.ex
Error while running Elixir.Credo.Check.Readability.Semicolons on lib/finch.ex
** (EXIT from #PID<0.95.0>) an exception was raised:
** (CaseClauseError) no case clause matching: {:ok, 22, 1, [], [{:eol, {21, 4, 1}}, {:end, {21, 1, nil}}, {:eol, {20, 6, 1}}, {:end, {20, 3, nil}}, {:eol, {19, 16, 1}}, {:bin_string, {19, 5, nil}, [{{19, 6, nil}, {19, 14, nil}, [{:identifier, {19, 8, ~c"reason"}, :reason}]}]}, {:eol, {18, 46, 1}}, {:do, {18, 44, nil}}, {:")", {18, 42, nil}}, {:"}", {18, 41, nil}}, {:identifier, {18, 35, ~c"reason"}, :reason}, {:kw_identifier, {18, 27, ~c"reason"}, :reason}, {:"{", {18, 26, nil}}, {:identifier, {18, 16, ~c"__MODULE__"}, :__MODULE__}, {:%, {18, 15, nil}}, {:"(", {18, 14, nil}}, {:paren_identifier, {18, 7, ~c"message"}, :message}, {:identifier, {18, 3, ~c"def"}, :def}, {:eol, {17, 13, 1}}, {true, {17, 9, nil}}, {:identifier, {17, 4, ~c"impl"}, :impl}, {:at_op, {17, 3, nil}, :@}, {:eol, {15, 6, 2}}, {:end, {15, 3, nil}}, {:eol, {14, 32, 1}}, {:"}", {14, 31, nil}}, {:identifier, {14, 25, ~c"reason"}, :reason}, {:kw_identifier, {14, 17, ~c"reason"}, :reason}, {:"{", {14, 16, nil}}, {:identifier, {14, 6, ~c"__MODULE__"}, :__MODULE__}, {:%, {14, 5, nil}}, {:eol, {13, 48, 1}}, {:do, {13, 46, nil}}, {:")", {13, 44, nil}}, {:identifier, {13, 38, ~c"reason"}, :reason}, {:"(", {13, 37, nil}}, {:paren_identifier, {13, 30, ~c"is_atom"}, :is_atom}, {:when_op, {13, 25, nil}, :when}, {:")", {13, 23, nil}}, {:identifier, {13, 17, ~c"reason"}, :reason}, {:"(", {13, 16, ...}}, {:paren_identifier, {13, ...}, :exception}, {:identifier, {...}, ...}, {:eol, ...}, {...}, ...], []}
(credo 1.7.3) lib/credo/code.ex:132: Credo.Code.to_tokens/2
(credo 1.7.3) lib/credo/check/readability/parentheses_in_condition.ex:36: Credo.Check.Readability.ParenthesesInCondition.run/2
(credo 1.7.3) lib/credo/check/readability/parentheses_in_condition.ex:2: Credo.Check.Readability.ParenthesesInCondition.do_run_on_source_file/3
(elixir 1.18.2) lib/task/supervised.ex:101: Task.Supervised.invoke_mfa/2
(elixir 1.18.2) lib/task/supervised.ex:36: Task.Supervised.reply/4
Thank you @kianmeng ! Always a pleasure |
🥳 🥳 🥳 🥳 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: