-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Fakegato history #157
base: master
Are you sure you want to change the base?
Conversation
Fixed a bug in debug call
…egram when no more mition is detected
Hi Carsten, that is great! However, it seems to be based on v0.3.19 instead of the current master, and that is why the file compare shows ancient artifacts, like the AccConstructor, which was the historic name back when it was a part of HAP-nodejs, long before Homebridge. Could you try to re-base the pull request to the newest master? I found that here: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request Besides that, I really like it! |
Hmmm..this is pretty strange. I pulled the current version from "your" Github version and compared it file by file with "my" version. Everything looks pretty okay. But I'll have a look at the Rebase and see if I can get this to work. |
Year, I think Git remembers when you forked the branch and bases everything on that version. So even if your files are identical to the current master, it will show the differences to 0.3.19 or whatever the base version was. |
The following changes have been added:
I'm still a big confused why the file comparison how things like:
var AccConstructor = require('./lib/knxdevice.js');
.vs.
var KNXDevice = require('./lib/knxdevice.js');
In the current master's index.js it says KNXDevice and so it does in my index.js. No idea where this AccConstructor comes from.